KnightMiner

Results 152 comments of KnightMiner

A laundry list of items to support is not a ton of help, as I'll have to research all those mods to find the expected output (and I don't have...

There is no forge API for drinkable fluids. So no easy way to solve this problem. Probably won't be fixed.

After updating code related to buckets, this might be feasible on 1.18+, so will look into it again in the future. Let me know which mods on 1.18 have drinkable...

Bug in Ex Nihilo, they are not using the forge system that makes it work with custom fluid containers. Nothing I can do to fix it without hardcoding to that...

As I have stated, my bucket use the forge system to work with other mods fluid tanks. They work with many other mods including Tinkers Construct and Thermal Expansion. If...

> I moved the registration to DeferredRegister As I asked in my previous PR, is this really nessesscary? I am not against deferred registers, but its a unneeded refactor.

The code I had before works exactly the same in 1.19. Registry events were just changed so instead of being generic, the registry is part of a getter. Object holders...

Lets do a single event subscriber for registration, no sense having multiple subscribers to the same event in the same class.

I was unable to successfully build a workspace from this PR, were there gradle wrapper or build.gradle changes you missed in the PR?

That would prevent the game from launching, not the entire workspace from building. You probably need to commit the required 1.19.2 changes to build.gradle (not commenting out the injection code,...