George Lester

Results 18 comments of George Lester

For what it's worth, I've used this for about two years on raspberry pi. Build the image(s) locally and it works great. EDIT: I'd initially had to remove 128-bit integer...

Thanks! And thanks for using the library! I looked through the issue you linked, and [this comment](https://github.com/casbin/casbin/issues/45#issuecomment-343703409) is correct; caching is probably a good move. [Parsing an expression](https://github.com/casbin/casbin/blob/433a72226663b56b43f1d87d4c582b99eb1da001/enforcer.go#L305) is the...

Added some findings in [the casbin issue](https://github.com/casbin/casbin/issues/45#issuecomment-343999100).

You're correct, every numeric value is treated as `float64` regardless of what type it was initially, and also yes, there's no epsilon-based equality checking for integers (internally, the `==` operator...

You're correct, that's a bug. I've got [a fix](https://github.com/Knetic/govaluate/commit/7aa6061a924917bbdf72d414fdcf9acae5745050), but there are a series of other changes I'm looking to make, and i'm not sure what order / version these...

The original problem is not supported yet, the initial implementation of accessors simply isn't smart enough to know that you can access the results of a function call. So something...

I highly suspect this is due to the brittle way this library handles parameter accessors (such as calling `foo.Bar()`). I've been unhappy with how they work for some time, but...

I'm still going over the change, but all the tests are passing and i think the change to quoting is fine - it always felt like a bug to allow...

This change is good, but I'm going to wait to merge until a new major version is ready - this is a big enough API break that it'll probably affect...

Huh, I'm surprised I didn't have a test case for this - this should work. But it looks like I only made test cases for when the prefixed value is...