Keith Lawrence
Keith Lawrence
Converting this into a draft - I need to add some automated tests to this to confirm it'll automatically handle the rates period rollover.
Is the span even doing anything useful? Like, could those P tags just be straight inside the enclosing div?
@selfthinker one possibility is using a markdown linter (eg https://github.com/markdownlint/markdownlint) with configurable rules. That would allow us to pick out some of the issues in your linked document. (Obviously it...
I'm going to close this issue as we now use DartSass for this app and although there are still a few kinks to work out in terms of CSS functions,...
Yes, that's correct - when the help pages got moved over (they were the first set to be moved), we didn't notice that government-frontend pages all had an implicit main...
> Think it would be News Article to be removed here in README? Lol, I wish I'd done that deliberately to see if people were paying attention. Instead, it was...
> Just a minor one - do we also remove news_article from application.scss? > > https://github.com/alphagov/government-frontend/blob/cbf103ea17f1022e738afb1cd024621a59bb5431/app/assets/stylesheets/application.scss#L29 > > I had removed that in Speech PR. Yep, that needs removing. I've...
@MartinJJones Interesting! There certainly seems to be precedent for gems: https://github.com/alphagov/govuk-dependabot-merger/blob/main/config/repos_opted_in.yml#L22C3-L22C19 ...gds-api-adapters among others are included in the list. I think I'd argue it's safe because in this case they...