govuk_publishing_components icon indicating copy to clipboard operation
govuk_publishing_components copied to clipboard

Published 20 hours ago • verified publisher icon alphagov

HTML validation bug in cookie banner

Open maxgds opened this issue 1 year ago • 2 comments

What:

Noted by Anika, https://gds.slack.com/archives/CARGH33JS/p1692285458097259 we have <p> tags inside a <span> tag in the cookie banner - the fix is probably to simply switch the span to a div.

Why:

No visible issues, but invalid HTML is not a good look. Affects all pages as the banner is presented to whatever page is the first landing page.

Prioritisation score: 3

Reach: 3, Severity: 1, Effort: 1

maxgds avatar Aug 18 '23 08:08 maxgds

Is the span even doing anything useful? Like, could those P tags just be straight inside the enclosing div?

KludgeKML avatar Aug 18 '23 08:08 KludgeKML

Is the span even doing anything useful? Like, could those P tags just be straight inside the enclosing div?

It's the parent container that gets hidden upon choosing a preference, so it does serve a purpose.

maxgds avatar Aug 18 '23 08:08 maxgds