Klemen

Results 255 comments of Klemen

Yes, a converter would be needed too

> Would it be alright to have the converter in another PR? I suggest making a new PR to this PR. I have reviewed most of this PR so when...

The PR looks good to me and is ready to be merged into this one

Thanks for the reviews, will merge soon after we kick off 2024.2 :)

> I expect A LOT of questions to this implementation 👀 If it is too uncommented and convoluted, I may have to close the PR and do it myself as...

Accidental close, my bad

> element order editor still works properly according to generated files. Please test in-game too to double-check. Thanks!

Tests don't like this. What was the scope of testing done on this, given it was implemented in a day? This is a very big change and will need more...

~~Ok in this case checking ordering in the code for tabs is correct is enough I guess.~~ You will need to use gradle at some point, so it would be...

> These extra days will postpone both PRs for who knows how many more versions though 🥺 The PR with tabs had time to be tested (it was open for...