Gerrit Uitslag

Results 358 comments of Gerrit Uitslag

I’m sorry, I’m not so known with xmlrpc. The problem is the ‘403 forbidden’? Could adding some echo debug statements to see in between results help to understand the work...

I’m not in the details of LDAP, so a bit of guessing here, but does current setup of the authldap plugin retrieve the group info properly from ldap? maybe adding...

Why is this related to php > 5.4?

Could we know or request the size limit of ldap from php?

This is logic consequence of removing it from git. But a more principal question, should we not keep the images for one release, to give plugin authors time to update?...

Should we not restore the gifs, and deprecate them this release. So that we can remove them next release according to the default depreciation scheme?

Here, issues opened at plugins https://github.com/splitbrain/dokuwiki/pull/3344#issuecomment-1007713674 . prosemirror and cgkedit were using the gifs explicitly. Most others are about svg vs gif.

The unit tests for the coreapi calls are here. As example deleteuser, but there are more of course: https://github.com/splitbrain/dokuwiki/blob/ba13c29839508a401a3a9b5bb4057dc6e50533c0/_test/tests/inc/remoteapicore.test.php#L453-L465 Note: it covers only correct input actually, no check of wrong...

It can be a part of coreApi, because `triggerUserMod()` is a core function. btw, by using `$auth->triggerUserMod()` instead of `$auth->createUser()`, the event trigger is also triggered.

If you have a first proposal, you can open a PR. Then we have there a look together for eventually remaining parts.