Krishna Ramasimha

Results 18 comments of Krishna Ramasimha

oh weird, the bot dm'ed me twice, must be a one time glitch. Thanks for letting me know chris, ill limit and edit the issue to only the second part

Yep, thats the issue currently

I'm sorry for the force pushes 😅 I forgot to add a few things and I didn't want to stack commits, so I rebased and pushed again.

> Since Janet is a lisp and looks a lot like clojure, I wonder if we can re-use the clojure or scheme parsers and only write new queries? Does "new...

Gotcha. Although, I do have a concern. Looking further into the syntax of all the 3 languages [ janet, clojure and scheme ], there seems to be quite a bit...

@the-mikedavis [Sorry for the mention!] Any update on this PR?

> Hmm yeah, we might as well pull in a new grammar for this - when compiled, this parser is only 174KB. We can work on deduplicating grammars later, maybe...

@rustbot author @edward-shen Hey! It looks like there are some merge conflicts in your PR. Can you sort them out? Once you're done type in `@rustbot review` here so that...

@rustbot claim I would like to take this issue up [with a bit of mentoring :)] if that's alright. It's my first time contributing!

Useful Links and Points for anyone who wants to work on this: Initial PR : https://github.com/rust-lang/rust/pull/101711 Revert of the Initial PR : https://github.com/rust-lang/rust/pull/101942 Attempt 2 : https://github.com/rust-lang/rust/pull/107956 Revert of attempt...