Leo Kirchner
Leo Kirchner
I don't really understand why exactly the CI is failing here, maybe somebody can restart it?
So this is an issue that doesn't pertain to my change then, right?
I have opted to go for a separate name for the method. I think this is less intrusive. Open points: - [ ] Should this be used anywhere here https://github.com/nautobot/nautobot/blob/93b2b0475409d7a3b85d4bd98e7b280411432cb6/nautobot/dcim/models/devices.py#L745?...
> In the new implementation, how is the performance at scale? Have you compared it to a naive for-loop (not using bulk-create) with change-logging enabled? Wondering in particular for the...
Here are the results: ```python import time import contextlib @contextlib.contextmanager def time_it(): before = time.process_time() yield after = time.process_time() print(f"Took {after - before}s.") ``` used as profiling tool. ```python def...
Going to re-visit once that's in. Thanks!
Closing this out for now as I have no expectation of working on it further. I guess its still relevant for things like #2459
Looks much better
I see some device42 commits in here, is this intended?
This is something I think would be useful but would definitely have to be configurable as I wouldn't like for it to be the default behaviour.