Brian King

Results 23 issues of Brian King

Easier to add a podspec than figure out the directions ;0 All that should be added is :tag => 0.1 in the s.source hash. I can't tag your repository, so...

Not sure what this error is, but on mountain lion, I'm getting: Failed to bless helper. Error: Error Domain=kSMErrorDomainFramework Code=3 "The operation couldn’t be completed. (kSMErrorDomainFramework error 3 - The...

I wish I had read this before I set up the schemes, but we should do this to clean up the project file: http://promisekit.org/news/2016/08/Multiplatform-Single-Scheme-Xcode-Projects/

enhancement

The macOS platform is pretty un-tested, and the unit tests just got became functional, but there are some failures. - [x] Font comparison isn't working. The fonts are the correct...

Given this type of style: ``` swift let string = try? NSAttributedString.composed( ofXML: content, baseStyle: .style( .font(UIFont(name: "GillSans-Light", size: 20)!), .lineHeightMultiple(1.8), .color(.darkGray)), rules: [ .style("black", .style( .color(.white), .backgroundColor(.black), .font(UIFont(name: "SuperClarendon-Black",...

When I run danger, xcode_summary is only printing the tests_summary_messages. I get the following comment reported ``` Messages: - [ ] Executed 165 tests, with 0 failures (0 unexpected) in...

Added some code for this. It's a bit crufty, but I wanted some feedback. Notes: - Not sure I manage the inFullScreen flag correctly in the cell, and I'm not...

I was tweaking our CI setup, and when my actions are `clean build test`, Danger wasn't able to find the debug information. It turns out that there are 3 `.xcactivitylog`...

There is a `placeholder` key on constraint. I'm not sure what this actually does. Very often it won't have enough information to generate a valid constraint and can cause failures.

Needs Investigation

If anyone has opinions on how to generate code for segues, please reply here!

Looking for Opinions