Moritz Borcherding

Results 153 comments of Moritz Borcherding

Normally error propagation is done via the `?` operator. If you define your own errors there need to be From/Into implementations for the error type that A returns that convert...

So this looks like a solid first step towards including basic but valid encoding into this project. There is always room for improvement but I think the API for the...

Hm actually this just came to my mind: The only place that currently creates an error is the conversion of the frame header to its serialized representation because the validity...

Hi! Signals are working, but they do require a little more work than that example. This example just sends out a signal (as the monitor shows) but it does not...

That's probably a good idea

The location of these files is based on the separation of this library into `params` and `traits`. I'll think about how to organize this better especially with the prospect of...

Hi! Thanks for doing this, any reason you aren't doing this as a Pull Request? I'm fine with just applying and checking the patch, just wondering :)

I see :) FYI I've started reviewing this in the branch https://github.com/KillingSpark/rustysd/tree/upgradedependencies

Hi! Depending on network and mounts is a pretty cool feature systemd has. The network thing has been a bane of linux init systems since for ever, and the systemd...

Huh that's true. I guess it should be "is_ascii" instead.