Moritz Borcherding

Results 153 comments of Moritz Borcherding

To elaborte on the environment variable thing: it is just unsafe to set an environment variable between fork and exec, because you cannot know if there wasn't another thread manipulating...

I played around with @akhilles proposal because I was interested in the opposite direction: making this faster with bigger lookup tables. The only drawback I can see is that it...

Oh that's clever! I am not completely sure whether this is a breaking change either. But as long as `Crc` still works it shouldn't be a breaking change. So for...

I'm sorry I don't understand what this is supposed to mean? Is there a difference in your code to the code above that I don't see?

Any blockers for the release? Having syn 2.0 would be very nice

> I suspect I don't need to clone the entire FrameDecoder struct to make this work; I don't think I need all the buffers it holds. I think you do...

Yep it's on my todo list, but if I'm not mistaken 1.0 is not yet released. Right?

I'd accept that, the thought crossed my mind too. I just didn't want to spend the time to actually implement it. If you have the motivation to do this, go...

We actually switched from thiserror_no_std to derive_more. I don't remember why and am on mobile so looking it up is a bit difficult. But I think if this issue is...

> Agree that create_answer should return errors rather than creating bad answers Tbh the error should probably be on `set_remote_description` I'll have a look into those sources maybe there are...