Arthmaël Poly

Results 39 comments of Arthmaël Poly

If the base function returns false then it is normal than the safe function return an exception. I don't know why you have an error but it doesn't come from...

But how do we know if there is an error without checking if the return is false?

According to the doc (https://www.php.net/manual/en/function.fgetcsv.php): > A blank line in a CSV file will be returned as an array comprising a single null field, and will not be treated as...

@pyrou I think I prefer the first solution since it doesn't require users to learn a new behavior. Working on it.

Do you think there are other functions that might have the same issue?

The fix was deployed in version 2.3, I will do a MR later for fgets

this should be easy to fix, i will just override the types from phpstan

I keep this issue onpen in case I missed some functions

You cannot juste edit the generated files, or your change will be overwritten when we generate from the doc. You need to edit the file CustomPhpStanFunctionMap.php to overwrite the typings