Arthmaël Poly
Arthmaël Poly
I am not sure I understand the link with rector but yes, that new structure looks good, i would definitly like a PR to do that, especially if it solves...
Hello, I am not sure this will be possible. Looking at the the doc: https://www.php.net/manual/fr/function.fgets.php, The function can also return FALSE once there is nothing left to read. All our...
> I've been actually surprised to see that your implementation only checks the return value, and does not systematically throw when a PHP error has been caught. Yes it is...
We have a special case file where we can manually write safe versions of functions. However, i don't think we can use the code you linked, because it is kind...
Sorry I completly missed this PR. I will update the phpstan recs this week
Maybe we could do the same thing for the annotation @template from phpstan. Or is it redundant with @psalm-template? More generally, if I want to remain compatible with both tools,...
Ok so I guess at first I can just focus on psalm annotations.
I think maybe the better idea would be to commit the documentation files that you want to use, otherwise a new personn won't be able to work on the branch...
The CI workflow use a cache (https://github.com/actions/cache) for the documentation file which may be reused between master and 1.x. It would probably be easier to just remove the caching step...
@ondrejmirtes now that phpstan does implement templates, do you think we can generate them in safe?