Arthmaël Poly comments

Results 39 comments of


                                            Arthmaël Poly

Use Psalm templated stubbed functions?

Yes good idea. However there is no way to automatically know which functions needs a template, so we need to get it from a documentation. Right now, the project can...

add Conditional types for psalm

Yes we already thoughtabout something like this in #185 but I didn't manage to do it. The information is just too much spread in too many places. I may look...

add Conditional types for psalm

Well that is the problem, I don't see any grunt work. What we need for that feature would be functions that take a method name as a parameter and return...

ob_end_clean signature isn't quite right, IMO

@jaydiablo Do you agree with @asherkin or do you still think we should do a special case for ob_end_clean?

TypeError: Argument 4 passed to yaml_parse_file() must be of the type array, null given

Are you explicitly passing null as an argument or using the default value?

TypeError: Argument 4 passed to yaml_parse_file() must be of the type array, null given

Do you still have the porblem when upgrading to v1.0?

Replace `error_get_last()` with a custom error handler

I am sorry, I didn't have the time to review your PR, i will check it this week. I also pinged @moufmouf who is much more expert in error_handlers

Mark pure function by Psalm

#172

Mark pure function by Psalm

@muglug how do you test your function isCallMapFunctionPure() ? Do you use some selected example that you know are pure or impure, or do you have a more general approach?

Safe compatibility with PHP 7.4 breaking changes for password_hash

#146