Khafra

bug: header value checks are too strict in fetch

3

## Bug Description https://github.com/nodejs/undici/blob/0964a83710467b994cc108d096e97f69dd54ac90/lib/core/request.js#L26 The regex here is too strict for `fetch` which causes a bunch of tests to fail: ``` { fail: '\x01' } { fail: '\x02' } {...

refactor: node-fetch to undici

16

Follow up to https://github.com/sapphiredev/plugins/pull/143 (and https://github.com/discordjs/discord.js/pull/6586)

use fetch utility to parse range header instead of custom one?

1

This: https://github.com/nodejs/undici/blob/af9aaea082267040aa4b3989a69abeb5e8913a27/lib/core/util.js#L461-L471 can now be replaced with: https://github.com/nodejs/undici/blob/af9aaea082267040aa4b3989a69abeb5e8913a27/lib/fetch/util.js#L1030 I think sharing more code between fetch and the rest of undici would be nice, especially now that fetch is supported in...

websocket over http2

2

Refs: https://github.com/nodejs/undici/pull/2061#issuecomment-1685395999

fetch error loses stack context

13

repro from #2328 without the Error.captureStackTrace in index.js: ``` NODE_V8_COVERAGE='./coverage/tmp' node test.mjs /var/github/undici/lib/compat/dispatcher-weakref.js:25 dispatcher.on('disconnect', () => { ^ TypeError: dispatcher.on is not a function at CompatFinalizer.register (/var/github/undici/lib/compat/dispatcher-weakref.js:25:16) at new Request...

test/redirect-request.js is flaky

4

its flaky on every version of node and every os in the ci. not sure what test is failing exactly

```js import { Request } from 'undici' import { ok, strictEqual } from 'node:assert' const controller = new AbortController(); const signal = controller.signal; const request = new Request('http://a', { signal...

websocket: use dataview

5

We use a dataview here for performance reasons. I should have addressed this in #2106 but I did not. Refs: https://github.com/nodejs/performance/issues/2

fetch: limit web streams usage in body mixin methods

9

The fetch spec requires us to create a new web Readable stream for every `Response` and `Request` object, which can likely be avoided in most cases. Given the following examples:...

feat: implement 0 dependency streaming multipart/form-data parser

15

This PR implements a multipart/form-data parser with a 1:1 match to busboy's API. This took me about a week to complete and many, many hours. I believe docs and types...