refactor: node-fetch to undici

[KhafraDev]

Follow up to https://github.com/sapphiredev/plugins/pull/143 (and https://github.com/discordjs/discord.js/pull/6586)

[favna]

It's that easy? wow...

[favna]

@sapphiredev pack

[sapphiredev[bot]]

Heya @Favna, I've started to run the deployment workflow on this PR. You can monitor the build here!

[sapphiredev[bot]]

The deployment workflow has finished successfully. You can install it for testing like so:

npm install @sapphire/plugin-editable-commands@pr-145
npm install @sapphire/plugin-api@pr-145
npm install @sapphire/plugin-i18next@pr-145
npm install @sapphire/plugin-logger@pr-145
npm install @sapphire/plugin-subcommands@pr-145

[KhafraDev]

It's that easy? wow...

It should be, hopefully :)

[favna]

I'll do a test using that PR deploy above tomorrow or later this week but whatever the case we'll be sure to land this before the soon scheduled release of Sapphire v-Next

[KhafraDev]

Sounds good, although both Web streams and Blob are both considered experimental currently which is causing the holdup to the discordjs pr.

[kyranet]

There are merge conflicts, please rebase.

[KhafraDev]

any idea how to fix the merge conflicts? they're not showing on my side, only here

[favna]

We've decided internally to merge this when DiscordJS merges discordjs/discord.js#6586

[UndiedGamer]

That pr in djs is closed, now what

[kyranet]

You wait for the one in /rest

[Rexogamer]

(for reference, the relevant pr is discordjs/discord.js#7747)

[kyranet]

There are merge conflicts that need resolving, but otherwise LGTM.

[KhafraDev]

Okay should be relatively good, still not familiar with yarn so I don't really know where the types change occurred (and I'm a little lazy)

Also I committed these changes directly to my fork's main branch nearly a year ago, which didn't make anything easier 😐

[favna]

FYI @KhafraDev this is scheduled for v4 so it won't be merged until we're closer to bringing that version out which will be a while. It's good to have ready nonetheless.