Khafra comments

Results 315 comments of


                                            Khafra

Use FinalizationRegistry to dump the socket if the Response is GC'd

```js const { fetch } = require('./index.js') async function run () { await fetch('https://example.com') } run() // otherwise process will end setTimeout(() => {}, 120000) ```

Remove `Symbol.dispose` integration in `setTimeout` and `setInterval`

I don't understand. You can already write new code that is incompatible between browsers and node.js by using the returned Timeout object. I see plenty of new code use .unref()...

Remove `Symbol.dispose` integration in `setTimeout` and `setInterval`

I think we are steering away from the topic - if there are no plans of deprecating or changing the return type, then I don't really see the justification for...

Semver Major Considerations

I'd like to drop FileLike and FileReader too.

Missing '\r\n' in last boundary of FormData

this looks similar to https://github.com/nodejs/undici/commit/fdeccc23b510bda706f5b62921a72ecdc593bda4

Missing '\r\n' in last boundary of FormData

``` node -p "`node: ${process.version}, undici: ${process.versions.undici}`" node: v22.15.0, undici: 6.21.2 ``` It seems like the commit didn't make it into the v6.21.2 release https://github.com/nodejs/undici/pull/4210

docs(fetch): add differences between Undici fetch and standard Fetch API

How is this different from https://github.com/nodejs/undici?tab=readme-ov-file#specification-compliance and https://github.com/nodejs/undici?tab=readme-ov-file#requestbody ?

fetch fail: cause: AggregateError [ETIMEDOUT]:

I am able to reliably repro it when fetching too many urls at once. https://github.com/nodejs/node-core-utils/issues/810

Set-Cookie header gets concatenated in fetch if an interceptor is in place

If receiving an array is expected, #4390 is fine. If it isn't, I think it'd be more beneficial to align the dispatcher header behavior (in general, since it seems like...

fix: avoid setup global dispatcher in advance

Would it make more sense for undici to always overwrite the global dispatcher (if it's not from undici already)? Importing `node:http` might not cause issues anymore, but you'd still have...