Khafra
Khafra
Yeah agreed. The forEach benchmarks are misleading because the implementation is now wrong (probably, I'd have to test it out). The WPTs must not cover inserting entries while iterating over...
I completely forgot I replaced MessageEvent lol
Performance - not measured yet. Autobahn - 100% https://khafradev.github.io/autobahn/clients/index.html
It was added under a flag.
``` test at test/node-test/debug.js:54:1 debug#fetch (346.571414ms) AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: 4 !== 6 at res. [as strictEqual] (/home/iojs/tmp/citgm_tmp/19886eeb-1a0b-44d6-951c-284ce1a45418/undici/node_modules/@matteo.collina/tspl/tspl.js:52:35) at Socket. (/home/iojs/tmp/citgm_tmp/19886eeb-1a0b-44d6-951c-284ce1a45418/undici/test/node-test/debug.js:79:12) at Socket.emit (node:events:531:35) at endReadableNT...
it looked like a different error to me, this test has had quite a few failures cc @metcoder95
``` test at test/issue-803.js:1:1 test/issue-803.js (30101.051783ms) 'test timed out after 30000ms' ``` @Uzlopak
understandable, I was hoping it would be minor enough for browser implementers to not mind lol
Bun also allows a dictionary as second parameter for setting custom headers, example [here](https://bun.sh/docs/api/websockets#connect-to-a-websocket-server).
it was also suggested in https://github.com/whatwg/websockets/issues/16#issuecomment-881547333 which I didn't know about