Kevin Van Cott comments

Results 256 comments of


                                            Kevin Van Cott

feat: add autoResetSorting

What's the use-case for this? Usually changing the sorting state without user-input is bad UX, right?

feat: add autoResetSorting

ok, open to merging this, but need to test more. Definitely agree that this should not be enabled by default like some of the other autoReset options though.

Improve typing for RowSelectionState

I think this exposes a bug in that code more than us needing to narrow the types more.

The `FiltersTableState` type is no longer exported after PR #5413, It's a breaking change.

sorry, didn't know anyone was using these internal types. It was renamed to `ColumnFiltersTableState`

fix(table-core): Avoid process not defined in environments not setting a process variable

What environments do that?

fix(table-core): Avoid process not defined in environments not setting a process variable

Are you sure that you're not accidentally importing from `src` instead of the proper build output? Also, maybe try importing from the `umd` output, which does not have any process.env...

fix(table-core): Avoid process not defined in environments not setting a process variable

> I'm also curious what the harm would be in detecting the process variable in the library before calling it? I have just never seen any other NPM library ever...

onColumnVisibilityChange behaves strange when clicked the show menu column showAll or hideAll button

Yeah, looks like there is nothing we can patch here in MRT, just have to recommend the ^above fix.

onColumnVisibilityChange behaves strange when clicked the show menu column showAll or hideAll button

If that API respects the enable hiding column def option the same way, then sure.

Missing props validation on Cell when defining columns

Either turn the lint rule off, or define the component elsewhere statically