table icon indicating copy to clipboard operation
table copied to clipboard

feat: add autoResetSorting

Open tychenjiajun opened this issue 1 year ago • 6 comments

tychenjiajun avatar Mar 16 '24 02:03 tychenjiajun

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 86a854c9f1cdc543491335fe1748e12825ac3e66. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Mar 16 '24 02:03 nx-cloud[bot]

What's the use-case for this? Usually changing the sorting state without user-input is bad UX, right?

KevinVandy avatar Mar 17 '24 19:03 KevinVandy

What's the use-case for this? Usually changing the sorting state without user-input is bad UX, right?

Personally I agree that changing the sorting state without user-input is bad UX. But there's still some designers prefer automatically resetting the sorting state when data changes.

tychenjiajun avatar Mar 18 '24 01:03 tychenjiajun

Also, see https://github.com/TanStack/table/discussions/5217

tychenjiajun avatar Mar 18 '24 01:03 tychenjiajun

ok, open to merging this, but need to test more. Definitely agree that this should not be enabled by default like some of the other autoReset options though.

KevinVandy avatar Mar 19 '24 05:03 KevinVandy