Kevin Grandon

Results 34 comments of Kevin Grandon

I believe that the desired outcome is a replacement for the existing npm package: https://www.npmjs.com/package/slimerjs E.g., a npm package which will download slimerjs as well as a copy of Firefox....

@laurentj - Would you consider accepting contributions to add NPM support? The primary change being just a package.json so we can download the scripts via NPM.

I'm working on a PoC which will download both SlimerJS as well as a copy of Firefox and have both installed into the node_modules/ folder. If I can get everything...

Yeah, that fork is still WIP and I'm evaluating the best way to move forward. After playing with it a bit I do think it would be nice to have...

> Downloading firefox is really not needed. People should just install it from their repos or firefox.com The reason I think that the npm package should download firefox is because...

Have you tried calling injectJs() right after the open() call?

Note: I haven't tested this locally yet, and this is just a guess as this was the only config missing the env: statement. We don't really need this anymore as...

Thank you very much for the pull request. Digging into figure out what's going on with the Fusion.js compiler is no easy task 😅 I'm going to leave this open...

That is truly boggling since we should just inject the `__DEV__` variable through a babel plugin, which I don't believe relies on any package name. It should be this line...

Thanks for filing a bug report. We should be transpiling node_modules, so it's strange that you're seeing this. Here is our test case around node_module transpilation: https://github.com/fusionjs/fusion-cli/blob/83894b4ff4018b8daf04e90db90cf7d997b628d9/test/compiler/api.js#L336-L368 We might need...