Kevin Fan
Kevin Fan
> What is the reasoning for this refactor? This PR conflicts with a WIP test refactor I am doing for making room to onboard EnvoyGateway. Basically I am creating "istio...
Closing this and opening up another PR since it's a big rebase
@guicassolato for task 2, it seems like there is some description missing "Update the status stanza of the AuthPolicy about route selectors that failed to" 🤔
Implementation steps looks good to me to cover the RFC suggestions 👍 I've updated the PR link for RateLimit WasmPlugin Controller as the intial PR has now been superseded by...
`WasmPlugin` has been updated to use `targetRef` as part of https://github.com/Kuadrant/kuadrant-operator/pull/612/files Similar can be done to `AuthorizationPolicy` at: https://github.com/Kuadrant/kuadrant-operator/blob/6823ed0d0f5be18d358d8f68163096c240366670/controllers/authpolicy_istio_authorizationpolicy.go#L90-L105
@didierofrivia can this be closed? 🤔 We have the integration tests running in parallel so not sure if this still needs to be addressed
I see this as a way for some maintainers (such as me) that typically make PRs from forks rather than branches to run the image build since the image build...
Going to close this as it doesn't look like it's a priority and not sure is this worth the security risk given the scope that the `pull_request_target` has to secrets...
TLSPolicy was done as part of https://github.com/Kuadrant/kuadrant-operator/pull/885 for if CertManager CRDs are not detected. This has not been done for any other Policies though
> I wondered if binding the `keys` root to the set of keys could have become an issue. Looking at the [API](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L6145) tho, there is not much we'd miss from...