Benoist

Results 85 comments of Benoist

@dvander @TheDS @peace-maker I believe you'll be the ones that want to look most at this, given it's pertaining to sourcehook. My goal is to have this PR merged, before...

> 1. `zlib` is now a dependency - this is different from the latest HEAD, and probably should be documented somewhere. I only had to install `zlib1g:i386` and this stopped...

Sorry for the long delay @adriansmares other x64 fixes took priority (namely sourcehook & dhooks). This should be enough for accelerator to work again on l4d2. @asherkin Zlib had to...

Not here to comment on the decision. But I'd suggest you fix the diff change on the PR, as it's currently impossible to review what you've added or removed. And...

> I'm not sure what you mean. It looks pretty clean to me. ~~It's really not though~~ Edit: Yeah it's fine if you hide whitespace change, but still I think...

### SDKType_Handle When CTakeDamageInfo & CGameTrace are not directly exposed to pawn there are no reasons for why a plugin would need that + to initiate such an object you...

Right i see what you mean, well then that's good but as for seperate type SDKType_CTakeDamageInfo and SDKType_CGameTrace shouldn't be made for the reasons i mentioned earlier and that would...

Removing CDetour isn't wise. Sourcemod afaik does not detour any function whose first assembly bytes are relative addressing operation ? but even if there are any in use, we could...

> Add to the uncertainty of your work being accepted. There's no reason to turn down contributions. Changing detouring libs has more uncertainties than fixing the present lib. > I...

> There are plenty of reasons, you just mentioned one of them. I've also seen contributions get turned down here as well, so I'm always thinking if I want to...