Ilya Kulakov

Results 232 comments of Ilya Kulakov

@Martiusweb What's the min version of Python you'd like to support in asynctest?

@Martiusweb Perhaps the decorator should also support class as it's target (i.e. setting timeout for all coroutines). The implementation might be changed to set an attribute on a function /...

@Martiusweb Any thoughts regarding that improvement?

I agree with your comment regarding the general purpose timeout decorator. There is at least [async_timeout](https://pypi.org/project/async_timeout/) (by aiohttp authors) for async code and [timeout-decorator](https://pypi.org/project/timeout-decorator/) for sync code. We can introduce...

Perhaps it makes sense to skip env vars initially and wait until someone else will request them.

@Martiusweb For this feature it's important to call `gc.collect()` after event loop is closed. The `_tearDown` method is called to soon for that. What would you suggest?

I cannot imagine a test that would suffer more than a couple ms from gc.collect, but that can be a made a separate configuration option. But I believe that it...

On the second thought, it can be removed and users can run it manually on demand. What has to be fixed is an ability to run checks _after_ the loop...

@Martiusweb Destruction is necessary to trigger the check. We could issue a warning if loop is still alive by the end of the test.

@Martiusweb Any thoughts regarding that improvement?