Ilya Kulakov
Ilya Kulakov
@ccordoba12 I will, but I'd like to understand the need for https://github.com/jupyter/qtconsole/commit/478f2437cd6b48f156031a58969678a716646d40 and https://github.com/jupyter/qtconsole/commit/f2785541618a940ad74363e6b28d0a542e3c1a87a. Could someone remove that code and test on Windows / Linux?
Please see my PR https://github.com/distillpub/post--momentum/pull/104 for the patch and reasoning.
:+1:
@asvetlov In this PR I also changed code to always cache ClientSession. Please let me know if this is bad. If so, I'd also like to add a comment to...
Thoughts: 1. Modify QueuedAioHttpTransport to be blocking 2. Keep track of what errors are already sent and discard duplicates
@meepoSenpai We should add implementation for `get_remaining_percentage` for all other platforms. Even if the implementation simply raises `NotImplementedError`.
Since it's an `@abstractmethod` it has to be implemented.
`get_remaining_percentage` must be implemented for Windows or Darwin before this can be merged.
@kootenpv What is the difference between `get_time_remaining_estimate` and `get_time_remaining`?
I will review this on the weekend, meanwhile take a look at the [tests](https://github.com/Kentzo/Power/blob/master/power/tests.py). Note that observing is not supported on Linux and Windows at the moment.