Ilya Kulakov

Results 232 comments of Ilya Kulakov

@lwouis Were you able to resolve the issue?

> Thus it seems that the NSEvent initializer worked, but that we have somehow an NSEvent which modifierFlags and keyCode are equal to 0. What value for `modifierFlags` did you...

> Could you please tell me a bit more about what this new commit goal is and how it tries to achieve it? Since event tap installed by SRAXGlobalShortcutMonitor intercepts...

That's fair, let's conduct further testing. Can you add the following code in your tap handler where your receive CGEvent from the system: ```swift let hasKeyCode = cgEvent.getIntegerValueField(.keyboardEventKeycode) != 0...

> What do you think about this theory? Being not thread safe is one thing, being main thread only is another. Apple's API by default is not thread safe but...

You're likely right. I will have to remove NSEvent-related API from the SRAXGlobalShortcutMonitor's handler.

@lwouis Do you have any feedback before I merge this?

> That would however mean I can't use SRAXGlobalShortcutMonitor which is another reason I have put the migration on hold for the time being. I can always add an additional...