Keith Henry

Results 54 comments of Keith Henry

@biggestcookie good idea! PRs welcome :) Otherwise I'll get round to it when I update the docs for the next release.

@dlh3 I'm not sure I want to make this change - it makes good sense to always get the return value, but I'm not sure there aren't contexts where the...

@dlh3 Cheers. That's a really nice way of programmatically finding all the methods with a callback function. I think there is a route to a programmatically configured API here, but...

Currently the definition files declare a namespace, which works with TS's default no modules pattern. I should update them to use ES6 modules, adding an `export default` to the definition...

An example is going to depend on the module model you're using. For JS: ```js // @ts-check /// ``` For TS: ```ts import './node_modules/chrome-extension-async/chrome-extension-async.js'; ``` _Should_ automatically pick up the...

Other than the additional hassle and time involved in going through https://github.com/types/_guidelines, none. I'll add it if there is demand for it, when I get time.

@notwaldorf Google Maps API adds global CSS and events that break if it is inside Shadow DOM For instance all inputs on the page are broken: https://issuetracker.google.com/issues/73644075 and the print...

Also, https://issuetracker.google.com/issues/35821412 is a bit of a deal breaker for any PWA.

This is a bug in the underlying Maps API when in Shadow DOM: https://issuetracker.google.com/issues/73644075 The only workaround I've found is to disable keyboard `keyboardShortcuts: false` and re-implement them.

@azakus Cheers! That fixes it, I think we just need to document it.