Vincent Prouillet comments

Results 1383 comments of


                                            Vincent Prouillet

Avoid creating empty/incomplete processed image files

Can you rebase by any chance?

Avoid creating empty/incomplete processed image files

Thanks!

Provide a better API for decoding a token without signature validation

Honestly, decoding a token without validating the signature is something that you shouldn't do most of the time so I do not particularly care about making it user friendly

Provide a better API for decoding a token without signature validation

Well you can't really trust any of the things you see in the claims unless you validate the signature

Provide a better API for decoding a token without signature validation

I'd take a PR for something like `jsonwebtoken::insecure_decode_without_signature_validation`

Provide a better API for decoding a token without signature validation

In practice there's no point validating a token where you don't validate the signature so that would be useless function to add.

Feature request : optionnaly use aws-lc-rs instead of ring

See https://github.com/Keats/jsonwebtoken/pull/377 It seems there are issues building it on Windows?

Feature request : optionnaly use aws-lc-rs instead of ring

I'd rather not have multiple backend if possible

Feature request : optionnaly use aws-lc-rs instead of ring

I don't mind that switch too much if it's easy to build on Windows. Another thing to consider is https://github.com/Keats/jsonwebtoken/pull/318 which removes Ring entirely and uses rust-crypto crates instead. Easier...

Feature request : optionnaly use aws-lc-rs instead of ring

I'm not sure what's the best way to go at it. #318 removes ring but we want to add a facade so maybe it could be done as starting a...