Kexiang Wang

Results 11 comments of Kexiang Wang

It seems I have no access to invite reviewers. @gforsyth @cpcloud @chloeh13q @deepyaman Could you please help take a review or invite the appropriate ones?

> We're unfortunately in the midst of a large internals refactor moving all backends to use sqlglot instead of sqlalchemy. It's OK. I have no experience on sqlplot. After the...

> It looks like the first order of business would be to rebase this PR on main. OK, I'll try my best.

Hi @cpcloud, I've rebased the PR to newest main and fix all the issue introduced by the `sqlglot` refactoring. Could you please help take a look. Besides, I find some...

> I wonder how generalizable this is across different streaming backends. Good question. These concepts are common in streaming backends, although different systems may have different names for them. For...

> If this PR allows maintainers to push updates, I can take on porting over your work here to the new naming and push that up. Thx @gforsyth . I...

Hi @gforsyth . Thanks for the effort. I've update the patch to this PR and I'll close https://github.com/ibis-project/ibis/pull/8781 when this PR is merged. Thanks!

@cpcloud @gforsyth Any further comments? Can we merge this PR now?

After a quick investigation here's reason: Our dependency chain on this is: risingwave -> [jsonbb](https://github.com/risingwavelabs/jsonbb) -> [serde_json](https://github.com/serde-rs/json) -> [ryn](https://github.com/dtolnay/ryu/tree/master). [Here](https://github.com/dtolnay/ryu/blob/f84f806d623e1d5623b5a4154f64b45cce436e7d/src/pretty/mod.rs#L83)'s the line of the code adding the ".0". Based on...

> always recording a (release) version may help. Yeah. Make sense. 👍