KarthikSubbarao

> Keyvi kivi > > Or some similar spelling. I recently went to New Zealand, if you haven't seen kiwi birds they are so adorable! +1. I was suggesting kiwi...

One small difference I noticed from BEFORE this commit and AFTER this commit. Before this commit, when a client is killed in the middle of a blocking command (example: BRPOP),...

>@KarthikSubbarao How complete is your module? What is done: * Support for the Bloom Filter Module commands (compatible with the ReBloom Module syntax): BF.ADD, BF.EXISTS, BF.INFO, BF.INSERT, BF.MADD, BF.MEXISTS, BF.RESERVE...

(Force pushed because this was recommended by the bot here since I did not include the commit sign off originally. Also because it is not reviewed yet)

> @KarthikSubbarao Overall LGTM. I do think we need to add more tests so that future changes will not introduce degradation. For example lets include function and redis.call cases ARE...

> @KarthikSubbarao I think this is somewhat problematic. Functions are more like modules IMO and I think we should allow function errors to overflow. I think maybe we can flag...

Sorry for the force push. I did not include the sign off on the previous commit and the DCO check required this

This run might have failed on a flaky test: https://github.com/valkey-io/valkey/actions/runs/9868728468/job/27251202927?pr=500 I re-ran it locally multiple times and the tests all passed

>does this https://github.com/redis/redis/pull/13141 can somehow solve your problem? @enjoy-binbin - (Just read the top comment) Yes, this will solve the issue of spamming `INFO ERRORSTATS` and reduce additional data stored...

>Resetting all the error count will also lose visibility into other errors like MOVED etc that can help with debugging issues in the cluster. Yes, looks like with the current...