Emil Kantis

Results 149 comments of Emil Kantis

Sure! Please split into smaller tasks, raise an issue and write something short about how you're thinking to proceed and we can take it from there? 😃 thanks for helping...

Sorry, the last item was closed with https://github.com/kotest/kotest/pull/3026 . All done ✅

Are you saying that ```kotlin val a = """ { "a": 1, "b": 2 }""" // b.json: """ { "b": 2, "a": 1 }""" a.shouldMatchJsonResource("b.json") // fail? ``` `shouldEqualJson` would...

I added a couple of tests here to check: https://github.com/kotest/kotest/commit/aa750b1e97402d948bbabde964b11f06edfb9361 Seems array order matters, and property order doesn't, which is in line with the [defaults for shouldEqualJson](https://github.com/kotest/kotest/blob/master/kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/compare.kt#L71). Perhaps we could...

What suggests that this is test sources? Looks like main sources to me (albeit on mobile. Might miss something)

I raised a [Youtrack issue](https://youtrack.jetbrains.com/issue/KT-52888/KotlinNative-17-breaks-backwards-compatability-for-compiler-plugins) for this.

@charleskorn 5.3.2 out now with the fix. Wanna give it a try? 😊

Sounds like it has some unfortunate consequences. Perhaps you could try dropping the `is Iterable` and see what tests fail as a result to help remember why it was added...

It seems to be in line with the spec (multiple properties allowed), but I don't see any harm in adding an extra flag to make it stricter and disallow it....

What if we used `@DslMarker` to restrict access to the root `Spec` when using `beforeTest`, `beforeEach`, `beforeAny`, `beforeContainer`, and `before` could be made available _only_ on `ContainerScope`. Would that make...