Kang Lin
Kang Lin
@eakraly @ggarber Please don't git rebase and git push -f in the master branch.
Let's do it ! The following tasks need to be completed: 1. MSVC features 1.1. Thread. Do you(@misi) consider std c++ 11 thread? 1.1.1. Thread synchronization (completed). see #719 1.2....
There are several methods: 1. Write completion threads for different operating systems from a fresh start 2. Using libevent-pthread, I don’t know if it’s cross-platform at the moment 3. Use...
@SamuelMarks I suggest you do it in the order of 4. -> 1.2 -> 2 :smile:
Yes. 2. 3. is simple and requires less work, but it will affect existing projects. 1 Simple modification requires a lot of work, but it will not affect existing projects....
This turn_mutex_init_recursive is not available in MSVC. Is it really needed in this project? If it is not necessary, consider removing ? @mom040267 @misi
@SamuelMarks I am know it is defined. I review the code. I don't think this feature is needed. So, I suggest to remove it.
In #855, The following changes have been made: 1. Replace deprecated functions with new standard functions 2. Add corresponding MSVC functions for non-standard functions 3. Remove warnings about unsafe functions...
@SamuelMarks Thank you are reviwe. I accepted some suggestions. I will wait for the project maintainer to decide how to modify the thread before starting subsequent server program modifications
> It's defined here: https://github.com/coturn/coturn/blob/9bcc898/src/apps/common/ns_turn_utils.c#L109-L133 > > You could probably use https://sourceforge.net/projects/pthreads4w if you wanted to stick with the pthreads API. But maintaining a proper MSVC threading interface might be...