Results 81 comments of Kang Lin

@ggarber Welcome you join. - This PR already contains #802 - See the beginning of this PR for the completed features of this PR. It compiles and runs in MSVC...

- I will schedule a time next week to finish 1 and 2 - _MSC_VER only is used MSVC. - WIN32, WINDOWS can is used MSVC and MINGW. This can...

@ggarber Please test #if defined(unix) || defined(unix) || defined(APPLE) || defined(DARWIN) || defined(MACH) in apple. If it is success. Then will be replace it with #if !defined(WINDOWS)

1/ Can you start by rebasing over master and resolving the conflicts? 2/ Do you know why your new CI jobs are not running in this PR? (it is the...

> Just trying to get a build working with [Microsoft] vcpkg on Windows 10 Pro 21H2 with Microsoft Visual Studio 2022 17.3.1. > > I feel that vcpkg might speedup...

@SamuelMarks Do you have time to add services?

> Just trying to get the build working with vcpkg. Might be that this PR is too big already and we just need it merged into master before proferring the...

Welcome @eakraly to joining this work. I do this work according to the following rules: - Guaranteed to do only one thing per commit. - Only modify the places where...

@eakraly I don't understand where I attacked you? Is there something wrong with the expression? I have only expressed the ideas and review suggestions of my work above. There is...

@eakraly If you still want to do a separate pr, then when you are done, I will rebase.