KIRA Ryouta
KIRA Ryouta
> 2 questions: > > * If we move to having a single background thread for loading, this logic and the atomics would get much easier, wouldn't it? If we...
> 2 questions: > > * If we move to having a single background thread for loading, this logic and the atomics would get much easier, wouldn't it? Oh do...
I think the processes become more safe.
> @KKQ-KKQ I'm sorry I've been way too swamped at work. I'm merging this without extensive testing so you can proceed. I'll test out things as they come when I...
I found that the following patch fixes the second test. ``` diff --git a/src/sfizz/Voice.cpp b/src/sfizz/Voice.cpp index 63db7cdb..e5233aac 100644 --- a/src/sfizz/Voice.cpp +++ b/src/sfizz/Voice.cpp @@ -1188,7 +1188,7 @@ void Voice::Impl::fillWithData(AudioSpan buffer) noexcept...
I found that the following patch fixes the first test. I'll make a pull request. ``` diff --git a/src/sfizz/ADSREnvelope.cpp b/src/sfizz/ADSREnvelope.cpp index 47907560..fa952373 100644 --- a/src/sfizz/ADSREnvelope.cpp +++ b/src/sfizz/ADSREnvelope.cpp @@ -101,7 +101,7...
@sagamusix Thanks for reporting. Now it is fixed on my repo. It probably works though it needs a lot of memory. [https://github.com/KKQ-KKQ/sf2convert](https://github.com/KKQ-KKQ/sf2convert)
I will do new Pull-Request.
I'm not familiar with Github, so I closed it. Sorry.
@acli In my personal opinion, the client should not quit by Ctrl-D or EOF in order to run as a background job. ~Could you use a "quit" command instead? Or...