kcaverly

Results 40 comments of kcaverly

This would help me broadly reason about the application a bit better as well. If the team is keen, I am happy to help out. Would it make sense to...

Looked into this a little bit, few thoughts: 1. There is a small if statement removing 'model' as a kwargs for azure calls. However, even if we include the model...

I've added a draft PR with the fixes from above, I am fairly confident it should fix the Azure bugs, would appreciate someone giving it a full test with proper...

Hey @JoeLoser - I got a working implementation up for `mmap` in Mojo. I wrapped up some of my thoughts, and provided a working example in the proposal here: #3218

Thanks @arnavsinghvi11, for the review. I can double check on the examples, and I agree with the comment on future refactors. I think two improvements for following up, would be:...

hey @arnavsinghvi11. I've incorporated the changes above, this should be good to merge. Let me know if there are any outstanding concerns.

Hey @krypticmouse! Weve still got ‘split_existing_split’ and ‘sample_split’. Which offer functionality to split existing splits, and sample/shuffle. I tried to make the base functionality more deterministic and consistent, but all...

Thanks for the response. Given this, would it be possible (and would you be open to a pr) in which we can load the documents to a vector store without...

This would be pretty useful for me, I’d be happy to give this a go this week.

Currently the new `BaseLM` returns a list of choices. But I think we could probably just simplify this to return a list of strings. As the strings are parsed and...