Jxck

Results 30 comments of Jxck

This is interesting topic. I'll check spec and code. @dimroth > most popular cookie libs don't Could you share some libs you mentioning here ?

I've checked the RFC specification. Cookie `parse()` checks valid characters while parsing https://github.com/honojs/hono/blob/1fafc7aec87f1afe68b37506df58a66acd9f29aa/src/utils/cookie.ts#L77 based on ABNF in RFC https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis-11#section-4.1.1 this ABNF is for producing cookie from server. It means that,...

for ease of review ```html x const $img = document.querySelector("#image") const $tooltip = document.querySelector("#tooltip") const $output = $tooltip.querySelector("output") $img.addEventListener("pinterover", () => { $output.textContent = $img.alt $tooltip.showPopover() }) $img.addEventListener("pinterleave", () =>...

@keithamus any other comments ?

To avoid extra effort, we would like to avoid modifications based on someone's preferences. Can I have a style guide for here ?

@josepharhar it's been done for now. PTL again plz.

Ah my fault. We can keep waiting for publishing RFC. Thanks!

@keithamus > you're suggesting the signal should call hidePopover after a certain time, is this correct? Yes. > Can you explain the broader motivating use case for this please? As...

I don't make sure this guideline really applicable for popover too. > The objective of this technique is to provide users with all the time they need to complete an...

> Going back to the original request That's my fault, so it just fine with `showPopover({ signal })`. > Any interaction that is timed fails the criterion. A which pops...