Jasey Waegebaert
Jasey Waegebaert
Great suggestion @milanholemans. Looks good to me!
@MathijsVerbeeck 🚀
Really love the implementation of the tags. I have nothing to add, the PR looks great from my perspective. Good job @martinlingstuyl 🚀
Hey @martinlingstuyl, before we continue with the review. Could you resolve the conflicts this PR currently has. 😄
Looks good to me. Great suggestion @appieschot!
Big fan of splitting the work!
Is there an update regarding this issue? I would love to have this feature within docusaurus, or the option to configure a custom baseUrl would also be nice.
My vote for system preference. Currently, I'm already using a dark version of the docs with a Firefox extension. Big fan of dark mode. 😄 So I don't really mind...
That's even a beter idea, This way we don't need to check if the `output` option is empty and the conditions used in the commands should be correct again. 😄
> If we ever removed or changed some of the CLI validation logic, commands would be none the wiser but would likely break on runtime with unhandled exceptions. Wouldn't it...