cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Rename `--title` to `--newTitle` for `spo list set` command and add `--title` and `--url` option

Open milanholemans opened this issue 3 years ago • 7 comments

The idea is to add extra options for the spo list set command to align it more with other spo commands that have a reference to a list.

  • Rename option --title to --newTitle
  • Introduce 2 new options --title and --url to reference the list
  • Current option id will become optional
Option Description
--title [title] Title of the list to update. Specify either title, id or url but not multiple.
--id [id] Id of the list to update. Specify either title, id or url but not multiple.
--url [url] Url of the list to update. Specify either title, id or url but not multiple.
--newTitle [newTitle] New title for the list.

milanholemans avatar Sep 18 '22 15:09 milanholemans

Great suggestion @milanholemans. Looks good to me!

Jwaegebaert avatar Sep 18 '22 20:09 Jwaegebaert

Putting this on hold until @waldekmastykarz finishes merging PR #3675 into the v6 branch.

milanholemans avatar Sep 21 '22 16:09 milanholemans

Awesome idea and we can pick up the work already including opening the PR as long as we don't merge the PR 😊

waldekmastykarz avatar Sep 21 '22 17:09 waldekmastykarz

Opening it back up again! 😄

milanholemans avatar Sep 21 '22 17:09 milanholemans

Should we split this issue into two by the way? Renaming the title option is a breaking change, and should be handled separately, with the old title option showing a deprecation warning.

What do you think?

Also: we need an third issue to remove the deprecation for v6

martinlingstuyl avatar Sep 21 '22 21:09 martinlingstuyl

That is indeed something we can do. The question is whether it is worth it to create 3 issues for this one while we can do it in 1 go in the v6 branch. That means that this change will be a bit later available, but since this is only 1-2 months it doesn't seem to bad to me. For me it doesn't really matter, 3 issues or 1 😊

milanholemans avatar Sep 21 '22 21:09 milanholemans

That's a good alternative. Let's make this a v6 issue in its entirety and keep it as one.

...aaaand it already is :)

martinlingstuyl avatar Sep 22 '22 04:09 martinlingstuyl

+1 to doing it at once in v6. A deprecation message at this stage is pretty late anyway, since v6 is just around the corner.

waldekmastykarz avatar Sep 23 '22 18:09 waldekmastykarz

I could work on this!

MathijsVerbeeck avatar Oct 12 '22 21:10 MathijsVerbeeck

@MathijsVerbeeck 🚀

Jwaegebaert avatar Oct 12 '22 21:10 Jwaegebaert