Justin Ray Angus

Any suggestions on how to fix the HIP tests failures?

> Thanks a lot, @JustinRayAngus! > > I am currently trying out your PR and while I am reading up on the new input options I found that the docs...

> @JustinRayAngus Sorry for the delay in reviewing this PR. I am finally giving it a finally round of review. In our discussions, I think that we considered moving some...

Charge conservation?

> @JustinRayAngus oopsi, can you please update/rebase? :) oopsi? I rebased just now.

I've looked into how rho/J are set at the boundaries and I found several bugs. Below is a comparison of the electric field energy for this problem obtained from the...

Thanks for the comment @ax3l. There is no division in these lines by vcms. So it is safe to remove the limit check.

@dpgrote @EZoni There is something funny going on with 1D. All CI tests are failing because executable cannot be found. I have no trouble compiling and running CI tests locally....

@EZoni I found a bug in one of the 1D implicit input decks related to changes made in this PR. I'm not sure why that would cause the problem mentioned...

@EZoni Found the issue. It was hard to find because it happens during the Build part of the 1D CI tests, which still gets a green checkmark even though it...