Justin Grote

Results 874 comments of Justin Grote

@joshmgross fixed up, please re-enable the workflow to test. It passed in my Actions: https://github.com/JustinGrote/vscode-github-actions-enhanced/actions/runs/13800804697/job/38602688747 b2c15d8eeecdb3e7d1f49f9807884ec938d9450d is a summary commit of the changes since last review

@joshmgross you removed yourself from this PR. Who should I be reviewing this with?

Added the referenced issues as sub-issues for fancy GitHub UI-ness EDIT: Also adding https://github.com/PowerShell/PowerShellEditorServices/issues/2191 because it will probably need to be fixed as part of this as well, even tho...

Thanks! Do we have a way to meaningfully test this? Do we need to spin up/add ARM to the testing matrix?

@andyleejordan you can get an ARM64 Windows VM on Azure. If we wanted automated tests we could set it up as a github action onprem runner. https://learn.microsoft.com/en-us/windows/arm/create-arm-vm EDIT: As of...

Thanks for the suggestion! As this isn't a core PowerShell language feature we probably won't implement it, however a separate vscode extension could definitely do this parsing and add that...

Thanks for your submission! This may be due to an interaction between PSReadline and the jsterm that is used in vscode. I don't think it is something we would be...

Is the explicit option super necessary or is this something we can auto-detect? Like the combination of the options `attach` and `script`

@jborean93 sorry, yes I am aware, this comment should have been on the actual implementation in PSES, sorry.