Justin Grote
Justin Grote
Rebased to re-run tests, they should pass now that the supply chain stuff has been fixed up.
@andyleejordan may want to enforce squash merges in the queue, this wasn't squashed so we have some slightly ugly commits in the tree now (not that it's that big a...
Fair enough, I'm still going to squash my PRs once they are ready (like that 200 commit rename one) so we can leave that to the PR author if you...
Rebasing to re-run tests, should be OK now.
Sorry, I meant to say the test should be fine, not that the pr is ready to be merged
> > I'd rely on your judgement, folks, on what to do with that further. We might have to redesign this part, to allow some kind of partial update of...
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_SetVariable A setvariable action isn't a net-new ID, it's updating an existing ID, so flushing the vars isn't necessary so I agree we need to make sure the cache is...
> We just had a discussion about this with @justingrote. The job of [ModuleFast](https://github.com/JustinGrote/ModuleFast) is to be super fast. Any retries could slow down the flow. For Sampler, the retries...
FYI this is carrying through to records with init properties and readonly record structs in C# 10, which are basically syntactic sugar wrappers around these properties.
@IISResetMe nice work! Does this just need tests added to be a viable PR to be reviewed?