Justin Grote

Results 875 comments of Justin Grote

@cyrkin thank you for persisting with additional information beyond our initial recommendation! Otherwise we wouldn't have caught it.

@andyleejordan is the Reactive DLL a direct dependency or something transitive from `csharp-language-server`?

Also, doing a sigcheck looks like the DLL itself hasn't changed in PSES from 2024.2.0 from 2024.3.2, so was this just a new detection that was a previous mis-signing? ![image](https://github.com/PowerShell/vscode-powershell/assets/15258962/3457ede2-ac1b-4ece-8c57-49bc36154bbe)

As an aside, I found the reference to `System.Reactive` which @TylerLeonhardt added 4 years ago C:\Users\JGrote\Projects\PowerShellEditorServices\test\PowerShellEditorServices.Test.E2E\Processes\ServerProcess.cs While we could unwind that, It is also referenced in OmniSharp.Extensions.JsonRPC as a transitive...

The Reactive DLL hasn't changed but it may have been being incorrectly signed as Microsoft First Party when it is in fact Microsoft Community, that was my main query to...

Can you more specifically provide an error? Also have you considered the `ImportExcel` module rather than using the Excel COM APIs directly? I currently cannot reproduce your code because it...

For what it's worth I'm currently reviewing the PSES part of this to hopefully help reduce the friction when the opportunity arises for a more thorough review.

Here is a build of the latest PSES rename changes. Lots of progress to go but it's here to test out: [powershell-2024.6.0-renameAlpha.vsix.zip](https://github.com/user-attachments/files/15594148/powershell-2024.6.0-renameAlpha.vsix.zip) You'll need to rename the .vsix.zip to just...

Caught here too: ```pwsh $NeededTools = @{ OpenSsl = 'openssl for macOS' PowerShellGet = 'PowerShellGet latest' InvokeBuild = 'InvokeBuild latest' } function getMissingTools () { $missingTools = @() if (needsOpenSsl)...