Justin Bisignano

icon company Anthropic icon location Denver, CO icon location Generalist software engineer focused on mobile products on Android

Results 2 issues of Justin Bisignano

Pinch to zoom zooms in to the top left corner

1 comment

When you enable zooming, pinch to zoom gestures seem to always zoom to the top left corner. This makes zooming unintuitive for the user. This is made worse by horizontal...

[optimization] Avoid unnecessary locking in single and scoped instances

[ScopedInstanceFactory](https://github.com/InsertKoinIO/koin/blob/74f91987ef94e63e8ea23ac9ed0ce24d6650d742/projects/core/koin-core/src/commonMain/kotlin/org/koin/core/instance/ScopedInstanceFactory.kt#L53) and [SingleInstanceFactory](https://github.com/InsertKoinIO/koin/blob/74f91987ef94e63e8ea23ac9ed0ce24d6650d742/projects/core/koin-core/src/commonMain/kotlin/org/koin/core/instance/SingleInstanceFactory.kt#L53) both lock on every call to `get`. This adds unnecessary overhead since locking is only required during the first initialization of an object. Koin should add [double-checked...