Alexey Lyakhov comments

Results 339 comments of


                                            Alexey Lyakhov

improved ts config, fixed types, insttead of PR 404

I've created a PR in https://github.com/ardatan/whatwg-node/issues/391 to fix extends conflict.

improved ts config, fixed types, insttead of PR 404

@beerose @ardatan please approve

improved ts config, fixed types, insttead of PR 404

@ardatan @beerose please approve. It is weird, that new issues coming up. I'm definitely checking everything with `yarn ts:check` before committing.

improved ts config, fixed types, insttead of PR 404

@ardatan @beerose something with env variables again

improved ts config, fixed types, insttead of PR 404

@ardatan @beerose resolved conflicts

improved ts config, fixed types, insttead of PR 404

@beerose @ardatan `error: PULUMI_ACCESS_TOKEN must be set for login during non-interactive CLI sessions` I'm not sure why env variables are missing. Not a part of my changes.

improved ts config, fixed types, insttead of PR 404

@ardatan you are correct, we have to resolve whatwg-node issue first.

improved ts config, fixed types, insttead of PR 404

@ardatan @beerose I've fixed merge conflicts

comparison to trpc

@n1ru4l For me, it is a great way to validate request and response, but rewrite whole thing to native fetch at the end to reduce the bundle size. Basically for...

Enable "exactOptionalPropertyTypes": true, in tsconfig.json

https://github.com/ardatan/feTS/pull/404 @beerose I left a lot of comments in places where I found appropriate. If you want me to change something or remove any comments, feel free to ping me...