ardatan
improved ts config, fixed types, insttead of PR 404
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Related # (issue) https://github.com/ardatan/feTS/issues/402
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- [ ] Test A
- [ ] Test B
Test Environment:
- OS:
-
package-name: - NodeJS:
Checklist:
- [ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests and linter rules pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
I've created a PR in https://github.com/ardatan/whatwg-node/issues/391 to fix extends conflict.
@ardatan @beerose please approve. It is weird, that new issues coming up. I'm definitely checking everything with yarn ts:check before committing.
@JustFly1984 I see some checks are failing — could you take a look at it?
@beerose @ardatan error: PULUMI_ACCESS_TOKEN must be set for login during non-interactive CLI sessions
I'm not sure why env variables are missing. Not a part of my changes.
We need to skip e2e workflows for forks in the workflow configuration because they use env vars that are unavailable to forks. So it is ok to ignore them for now.
Besides that, I think this PR is blocked by the one in whatwg-node right? Because this is not expected. https://github.com/ardatan/feTS/pull/407/files#diff-42c1d4716dbb2d085d517720a6e1dc424abac44a90ca85dc940b5619f6108054R123
