JunhongMao

Results 17 comments of JunhongMao

@judyjoseph , @mlok-nokia , please help to review this PR. Thanks.

@judyjoseph , @mlok-nokia , please help to review this PR. Thanks.

@sripathikrishnan , this PR is beneficial for my current project, please review and approve it as soon as possible. Currently, my project uses this PR as a patch. Merging it...

This PR https://github.com/sonic-net/sonic-buildimage/pull/18578 has been replaced by the below new PRS: https://github.com/nokia/sonic-platform/pull/6 https://github.com/sonic-net/sonic-utilities/pull/3283 https://github.com/sonic-net/sonic-platform-daemons/pull/475

Hello, @xincunli-sonic, I'm working on the unit test codes development for this PR. Now I couldn't compile an image including your modification. The error is below. Could you help provide...

There is a problem: the command "config apply-patch" caused some containers to exit. ``` admin@ixre-egl-board40:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES baeabdcd38a9 70dd58e31088 "/usr/local/bin/supe…" 2 hours...

> you will need to pass code coverage to merge this OK. Besides, I have a question. There was an error at the stage of CodeQL / Analyze (cpp) (pull_request_target)...

> this is for codeql ? Yes. And for the error during the stage of coverage.Azure.sonic-sairedis.amd64, I think I need add unit test codes to fix them, right?

Hi, @kcudnik. I looked into the subdirectories: sonic-sairedis/tests and sonic-sairedis/unittest, there are not any existed saidump test codes. How did the previous saidump codes pass the code coverage test? Need...

Hi, @kcudnik @gechiang, @mlok-nokia, the PRs of the similar modification have merged into the master branch. This PR is only intended to fix a compiling error of 202305 branch. Could...