Eng Zer Jun

refactor: replace strings.Replace with strings.ReplaceAll

2

### Description Replace `strings.Replace(s, old, new, -1)` with `strings.ReplaceAll(s, old, new)`. `strings.ReplaceAll` is a wrapper function for `strings.Replace`, but `strings.ReplaceAll` is more readable and removes the hardcoded `-1`. ### PR...

test: replace defer cleanup with `t.Cleanup`

1

## Change Description Follow up of comment https://github.com/lightningnetwork/lnd/pull/6710#pullrequestreview-1082647392, this PR replaces `defer cleanup()` calls with `t.Cleanup` in tests. The main reason for using `t.Cleanup` is to simplify the resource creation...

**What this PR does / why we need it**: The `io/ioutil` package has been deprecated in Go 1.16 (See https://pkg.go.dev/io/ioutil). This PR replaces the existing `io/ioutil` functions with their new...

refactor: use `os.ReadDir` for lightweight directory reading

6

# Description This PR replaces all `ioutil.ReadDir` to `os.ReadDir`. `ioutil.ReadDir` has been deprecated in Go 1.16. The new `os.ReadDir` is a more efficient implementation than `ioutil.ReadDir`. The full proposal can...

Replace deprecated `io/ioutil` with `io` and `os` packages

1

**What this PR does / why we need it**: The `io/ioutil` package has been deprecated in Go 1.16 (See https://pkg.go.dev/io/ioutil). This PR replaces the existing `io/ioutil` functions with their new...

Replace `io/ioutil` with `io` and `os` packages

12

The `io/ioutil` package has been deprecated in Go 1.16 (See https://pkg.go.dev/io/ioutil). This PR replaces the existing `io/ioutil` functions with their new definitions in `io` and `os` packages. - `ioutil.Discard` =>...

refactor: move from io/ioutil to io and os packages

1

The `io/ioutil` package has been deprecated in Go 1.16 (See https://pkg.go.dev/io/ioutil). This PR replaces the existing `io/ioutil` functions with their new definitions in `io` and `os` packages. - `ioutil.Discard` =>...

test: use `T.Setenv` to set env vars in tests

1

This PR replaces `os.Setenv` with `t.Setenv`. Starting from Go 1.17, we can use `t.Setenv` to set environment variable in test. The environment variable is automatically restored to its original value...

test: use `T.TempDir` to create temporary test directory

1

A testing cleanup. This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is...

A testing cleanup. This pull request replaces `ioutil.TempDir` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is...