Jun Nishimura
Jun Nishimura
@kubakl I have implemented it as you have shown as an example in the following way, but I could not reproduce the bug. ```go type Child struct { ID int...
@pkieltyka Hi, I submitted a PR(#89)! I would appreciate it if you could check it out.
Thanks, @marckhouzam Your point was right. I didn't notice that my previous code caused some regressions. And, I appreciate the alternative suggestions. I implemented your suggestions in the code. I...
Thanks, @marckhouzam I understand the situation. I'm so glad to know the algorithm of cobra thanks to your points. I implemented to call root's PersistentPreRun in sub-command's (help and completion)...
Thanks, @marckhouzam Your point is right. My implementation did not take into account the possibility that root.PersistentPreRun is nil. I modified to use PersitentPreRunE to be able to propagate any...
Thanks, @marckhouzam I define a constant for "true" named `trueString`. The name `trueString` might be too direct, so if you have a better name, please let me know and I...
@jpmcb Hi! How about this PR? If you haven't seen it because you are busy or for some reasons, that's perfectly fine, as I do not want to rush you....
@marckhouzam @jpmcb Sorry for the late reply. I resolved the conflict. I would appreciate it if you check this PR again!!
@jpmcb Thanks for checking the PR!! One question, do I need to ask one more person to review this PR to merge it into the main branch?
@marckhouzam @jpmcb Sorry it took so long to reply. > Is that what we want or do you prefer to help the developer notice their mistake? I thought it would...