Jun He
Jun He
Thanks for the comments, @terrelln . I understand the maintenance effort for an assembly implementation. Following is the change comparison between C and ASM for silesia at L8. Pls check....
The C version is a kind of "rewritten asm in C" of [huf_decompress_amd64.S](https://github.com/facebook/zstd/blob/dev/lib/decompress/huf_decompress_amd64.S). I started the porting on Arm with C, then hand tuned asm version for both 4x1 and...
Sorry for just jumping in for a related copyright question. 😄 Is a new file, like the new .S file in #3155 required to share copyright with Meta? I saw...
This patch changes the comparison in the loop of longest match from 1B to 4B. This extended comparison is safe as we compare the byte starting from match[3] and ip[3],...
@terrelln , @embg , anything I need to update on this PR? Thanks.
@embg , @Cyan4973 , thanks for the comments. Patch has been updated to reflect these.
The image (bigtop/puppet:trunk-centos-7-aarch64) is not provided on dockhub. You need to build it locally. For all valid images at present, pls check here: https://hub.docker.com/r/bigtop/puppet/tags To build a bigtop-* docker image,...
Thanks for the patch, @epikhinm . I'll try this patch and see if the bigtop packages work on Ubuntu-18.04.
@leolb-aphp , that looks great. Thanks a lot for your contribution. I triggered CI to test this PR, seems packaging passed while smoke test failed: https://ci.bigtop.apache.org/job/github-pr-check/19/DISTRO=ubuntu-16.04,PLATFORM=aarch64-slave/console https://ci.bigtop.apache.org/job/github-pr-check/19/DISTRO=centos-7,PLATFORM=aarch64-slave/console
@leolb-aphp , take care.