Julian Waller
Julian Waller
One thing to figure out here is should the package be called 'cef' or 'casparcg-cef'? I called the one in the ppa 'casparcg-cef' to ensure that it wont conflict with...
I'm still not sure whether I agree that libcef being reusable is good, or whether I prefer to have it isolated/namespaced..
I think the reason I did this is that sending `{ abc: undefined }` over IPC will likely result in `abc` disappearing from the object entirely. Passing it as an...
@thedist That all sounds fine with me. I am still curious on this though: > What would be the impact of leaving the object -> array conversion inside module-base, and...
I'm curious if JSON.stringify would be any faster? I am thinking that maybe we could do something weird like: ``` ejson.stringify({ // the general ipc layer type: 'setVariables' values: JSON.stringify(.....)...
I was curious about my questions here, so have taken a very quick look into some synthetic tests. It looks like doing a pre-stringify would be faster than letting ejson...
I haven't tested it yet, but I am committing to at least attempting to make it work without ejson when module-base hits v2.0 https://github.com/bitfocus/companion-module-base/commit/44b19a8877f04677a4cde4bd218848c1d329b340. The only use facing api change...
I think that trying to mix in a worker_thread for something here will be a bit of a challenge to do with any performance benefit. As most of the cost...
@jswalden I hadnt reaslised that MessagePorts could be passed between threads, so I suppose we could have a thread handling this per module. But I am still not keen on...
That auto-parsing is being planned as part of https://github.com/bitfocus/companion/issues/2345, which might happen at some point this year. I dont think we have agreed yet on how breaking this change would...